Skip to content

Add onMoveShouldSetResponder to element enabled checking #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Add onMoveShouldSetResponder to element enabled checking #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e911d7
fix: add onMoveShouldSetResponder to element enabled checking
abmantis Oct 22, 2020
5182d24
Update src/fireEvent.js
thymikee Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/__tests__/fireEvent.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React from 'react';
import {
View,
TouchableOpacity,
PanResponder,
Pressable,
Text,
ScrollView,
Expand Down Expand Up @@ -305,3 +306,27 @@ test('is not fooled by non-responder wrapping host elements', () => {
fireEvent.press(screen.getByText('Trigger'));
expect(handlePress).not.toHaveBeenCalled();
});

function TestDraggableComponent({ onDrag }) {
const responderHandlers = PanResponder.create({
onMoveShouldSetPanResponder: (_evt, _gestureState) => true,
onPanResponderMove: onDrag,
}).panHandlers;

return (
<View {...responderHandlers}>
<Text>Trigger</Text>
</View>
);
}

test('has only onMove', () => {
const handleDrag = jest.fn();

const screen = render(<TestDraggableComponent onDrag={handleDrag} />);

fireEvent(screen.getByText('Trigger'), 'responderMove', {
touchHistory: { mostRecentTimeStamp: '2', touchBank: [] },
});
expect(handleDrag).toHaveBeenCalled();
});
7 changes: 6 additions & 1 deletion src/fireEvent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@ const isEventEnabled = (
) => {
if (isTextInput(element)) return element?.props.editable !== false;

return touchResponder?.props.onStartShouldSetResponder?.() !== false;
const touchStart = touchResponder?.props.onStartShouldSetResponder?.();
const touchMove = touchResponder?.props.onMoveShouldSetResponder?.();

if (touchStart || touchMove) return true;

return touchStart === undefined && touchMove === undefined;
};

const findEventHandler = (
Expand Down