Add onMoveShouldSetResponder to element enabled checking #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmantis
force-pushed
the
responeder_move_event
branch
from
97021aa to
b56bb81
Compare
|
Can you add a test? 🙂 |
abmantis
force-pushed
the
responeder_move_event
branch
from
b56bb81 to
cb9b088
Compare
thymikee
reviewed
Oct 24, 2020
thymikee
approved these changes
Oct 24, 2020
abmantis
force-pushed
the
responeder_move_event
branch
from
cb9b088 to
3e911d7
Compare
|
@mdjastrzebski Any input? |
mdjastrzebski
approved these changes
Nov 3, 2020
Co-authored-by: Maciej Jastrzebski <mdjastrzebski@gmail.com>
|
Thank you for your contribution @abmantis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enables elements that have onMoveShouldSetResponder returning true, but not onStartShouldSetResponder.
Fixes #576 .
Test plan