-
Notifications
You must be signed in to change notification settings - Fork 274
within
operator for bound queries
#306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thymikee
merged 9 commits into
callstack:master
from
mdjastrzebski:feature/within-operator
May 14, 2020
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
17c22f2
Basic within implementation and tests
mdjastrzebski e8284fd
Added typescript types & tests
mdjastrzebski 967163f
Removed duplicated import in index.d.ts
mdjastrzebski d679ca6
Reversed prettier run on typings
mdjastrzebski 4bdf8f0
Fixed package level exports for `within` operator
mdjastrzebski 79c2c6d
Replaced getByTestId queries with getByA11yHint queries in unit tests…
mdjastrzebski 98e57d0
Added `within` section to API.md
mdjastrzebski c731da3
Updated README.md regarding `within` operator
mdjastrzebski 4b3ec79
Update website/docs/API.md
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
// @flow | ||
import React from 'react'; | ||
import { View, Text, TextInput } from 'react-native'; | ||
import { render, within } from '..'; | ||
|
||
test('within() exposes basic queries', () => { | ||
const rootQueries = render( | ||
<View> | ||
<View accessibilityHint="first"> | ||
<Text>Same Text</Text> | ||
<TextInput value="Same Value" placeholder="Same Placeholder" /> | ||
</View> | ||
<View accessibilityHint="second"> | ||
<Text>Same Text</Text> | ||
<TextInput value="Same Value" placeholder="Same Placeholder" /> | ||
</View> | ||
</View> | ||
); | ||
|
||
expect(rootQueries.getAllByText('Same Text')).toHaveLength(2); | ||
expect(rootQueries.getAllByDisplayValue('Same Value')).toHaveLength(2); | ||
expect(rootQueries.getAllByPlaceholder('Same Placeholder')).toHaveLength(2); | ||
|
||
const firstQueries = within(rootQueries.getByA11yHint('first')); | ||
expect(firstQueries.getAllByText('Same Text')).toHaveLength(1); | ||
expect(firstQueries.getByText('Same Text')).toBeTruthy(); | ||
expect(firstQueries.queryAllByText('Same Text')).toHaveLength(1); | ||
expect(firstQueries.queryByText('Same Text')).toBeTruthy(); | ||
expect(firstQueries.getByDisplayValue('Same Value')).toBeTruthy(); | ||
expect(firstQueries.getByPlaceholder('Same Placeholder')).toBeTruthy(); | ||
|
||
const secondQueries = within(rootQueries.getByA11yHint('second')); | ||
expect(secondQueries.getAllByText('Same Text')).toHaveLength(1); | ||
expect(secondQueries.getByText('Same Text')).toBeTruthy(); | ||
expect(secondQueries.queryAllByText('Same Text')).toHaveLength(1); | ||
expect(secondQueries.queryByText('Same Text')).toBeTruthy(); | ||
expect(secondQueries.getByDisplayValue('Same Value')).toBeTruthy(); | ||
expect(secondQueries.getByPlaceholder('Same Placeholder')).toBeTruthy(); | ||
}); | ||
|
||
test('within() exposes a11y queries', () => { | ||
const rootQueries = render( | ||
<View> | ||
<View accessibilityHint="first"> | ||
<TextInput | ||
value="Same Value" | ||
accessibilityLabel="Same Label" | ||
accessibilityHint="Same Hint" | ||
/> | ||
</View> | ||
<View accessibilityHint="second"> | ||
<TextInput | ||
value="Same Value" | ||
accessibilityLabel="Same Label" | ||
accessibilityHint="Same Hint" | ||
/> | ||
</View> | ||
</View> | ||
); | ||
|
||
expect(rootQueries.getAllByA11yLabel('Same Label')).toHaveLength(2); | ||
expect(rootQueries.getAllByA11yHint('Same Hint')).toHaveLength(2); | ||
|
||
const firstQueries = within(rootQueries.getByA11yHint('first')); | ||
expect(firstQueries.getByA11yLabel('Same Label')).toBeTruthy(); | ||
expect(firstQueries.getByA11yHint('Same Hint')).toBeTruthy(); | ||
|
||
const secondQueries = within(rootQueries.getByA11yHint('second')); | ||
expect(secondQueries.getAllByA11yLabel('Same Label')).toHaveLength(1); | ||
expect(secondQueries.getAllByA11yHint('Same Hint')).toHaveLength(1); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// @flow | ||
import { getByAPI } from './helpers/getByAPI'; | ||
import { queryByAPI } from './helpers/queryByAPI'; | ||
import a11yAPI from './helpers/a11yAPI'; | ||
|
||
export default function within(instance: ReactTestInstance) { | ||
return { | ||
...getByAPI(instance), | ||
...queryByAPI(instance), | ||
...a11yAPI(instance), | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could merge these 2 tests, but no biggie