within operator for bound queries
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
May 14, 2020
thymikee
reviewed
May 14, 2020
thymikee
reviewed
May 14, 2020
|
Missing the docs :) |
|
Added docs for |
thymikee
approved these changes
May 14, 2020
| expect(secondQueries.getByPlaceholder('Same Placeholder')).toBeTruthy(); | ||
| }); | ||
|
|
||
| test('within() exposes a11y queries', () => { |
There was a problem hiding this comment.
I think we could merge these 2 tests, but no biggie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit implements #297. New
withinoperator, inspired by RTL operator of the same name exposes queries bound to given element.Available queries are the same as those from
render(so getBy, queryBy, incl. A11y). Additionalrenderspecific operations likeupdate,unmount,debug,toJSONare NOT included.Test plan
Added unit test for within operator as well as typescript type definitions tests.