-
Notifications
You must be signed in to change notification settings - Fork 274
docs: migrate to Docusaurus v2 #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does it make #226 obsolete? |
In a way, yes. This was not just changing the versions, but a few details were modified to fit the version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
cc @yangshun anything obvious we missed during the migration? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left small suggestions!
import classnames from 'classnames'; | ||
import PropTypes from 'prop-types'; | ||
import useBaseUrl from '@docusaurus/useBaseUrl'; | ||
import styles from '../css/index.module.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use @site/src/css/index.module.css
instead of relative paths so that if you move this component around it wouldn't break :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only one level up, so I don't mind, but thanks for suggestion!
Summary
Migration of the website from Docusaurus v1 to Docusaurus v2.0.0-alpha.54
Closes #225
Closes #226