Skip to content

docs: migrate to Docusaurus v2 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2020
Merged

docs: migrate to Docusaurus v2 #299

merged 7 commits into from
May 13, 2020

Conversation

cross19xx
Copy link
Contributor

@cross19xx cross19xx commented May 11, 2020

Summary

Migration of the website from Docusaurus v1 to Docusaurus v2.0.0-alpha.54

Closes #225
Closes #226

@cross19xx cross19xx marked this pull request as draft May 11, 2020 11:23
@thymikee
Copy link
Member

Does it make #226 obsolete?

@cross19xx
Copy link
Contributor Author

In a way, yes.

This was not just changing the versions, but a few details were modified to fit the version

@thymikee thymikee changed the title Migration to Docusaurus v2.0.0 docs: migrate to Docusaurus v2 May 11, 2020
@thymikee thymikee marked this pull request as ready for review May 11, 2020 18:03
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@thymikee
Copy link
Member

cc @yangshun anything obvious we missed during the migration? :)

Copy link

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left small suggestions!

import classnames from 'classnames';
import PropTypes from 'prop-types';
import useBaseUrl from '@docusaurus/useBaseUrl';
import styles from '../css/index.module.css';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use @site/src/css/index.module.css instead of relative paths so that if you move this component around it wouldn't break :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only one level up, so I don't mind, but thanks for suggestion!

@thymikee thymikee merged commit 58055d8 into master May 13, 2020
@thymikee thymikee deleted the website-v2 branch May 13, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration Website to Docusaurus 2 Alpha
3 participants