Skip to content

docs: migrate Docusaurus to v2 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

docs: migrate Docusaurus to v2 #226

wants to merge 6 commits into from

Conversation

Croftyland
Copy link

@Croftyland Croftyland commented Oct 16, 2019

Summary

Migration from v1 to v2

Test plan

Hi, @yangshun, please check react native testing library as an example of resolved issue "migrate react native testing library to v2 #226 "

@Croftyland
Copy link
Author

@brooksbecton I couldn't understand what you have done

@Croftyland
Copy link
Author

Croftyland commented Oct 17, 2019

@thymikee all your comments were done

Please, @thymikee, @yangshun check

@lex111
Copy link

lex111 commented Oct 17, 2019

@Croftyland why did you remove Docker? Please bring it back, and just delete the removed paths in Docker files.

@Croftyland
Copy link
Author

Croftyland commented Oct 17, 2019

@lex111, is anything else ok?

@endiliey
Copy link

You might want to deploy it somewhere (eg: netlify or now) for live demo

Copy link

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the migration! Try to understand what each section of the code is doing as I see quite a bit of remnants from v1 which aren't relevant to v2.

Let's also try to get a demo running.

Copy link
Author

@Croftyland Croftyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangshun everything has fixed

@yangshun
Copy link

@thymikee please review again 😄

@thymikee
Copy link
Member

cc @lex111 for another review. I'll check it myself soon

@lex111
Copy link

lex111 commented Oct 28, 2019

Unfortunately, there are many conversations/suggestions marked as resolved, but not actually fixed :(

@thymikee
Copy link
Member

@Croftyland would you be able to address them? 🙂

@yangshun
Copy link

@Croftyland friendly ping :) Let us know if you need help and we can help out with the last few items

@Croftyland
Copy link
Author

I can't guess what's wrong with footer if we don't need it

Anything else is fixed, please check

@thymikee thymikee changed the title migrate react native testing library to v2 docs: migrate Docusaurus to v2 Jan 23, 2020
@thymikee
Copy link
Member

We're following up on this topic here: #299. Sorry it took so long, but Docusaurus grew a lot better since this PR started and adopted some users, like React Navigation. I hope to merge the migration in a few days :)

Thank you very much for your work ❤️

@thymikee thymikee closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants