-
Notifications
You must be signed in to change notification settings - Fork 274
docs: migrate Docusaurus to v2 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: migrate Docusaurus to v2 #226
Conversation
@brooksbecton I couldn't understand what you have done |
@Croftyland why did you remove Docker? Please bring it back, and just delete the removed paths in Docker files. |
@lex111, is anything else ok? |
You might want to deploy it somewhere (eg: netlify or now) for live demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on the migration! Try to understand what each section of the code is doing as I see quite a bit of remnants from v1 which aren't relevant to v2.
Let's also try to get a demo running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yangshun everything has fixed
@thymikee please review again 😄 |
cc @lex111 for another review. I'll check it myself soon |
Unfortunately, there are many conversations/suggestions marked as resolved, but not actually fixed :( |
@Croftyland would you be able to address them? 🙂 |
@Croftyland friendly ping :) Let us know if you need help and we can help out with the last few items |
I can't guess what's wrong with footer if we don't need it Anything else is fixed, please check |
We're following up on this topic here: #299. Sorry it took so long, but Docusaurus grew a lot better since this PR started and adopted some users, like React Navigation. I hope to merge the migration in a few days :) Thank you very much for your work ❤️ |
Summary
Migration from v1 to v2
Test plan
Hi, @yangshun, please check react native testing library as an example of resolved issue "migrate react native testing library to v2 #226 "