Skip to content

Shebang handling #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Conversation

przepompownia
Copy link

No description provided.

@przepompownia
Copy link
Author

At the moment this PR merges only the current master into shebang-handling.
See #47

@skovhus
Copy link
Collaborator

skovhus commented Nov 6, 2019

A bit hard to read this PR. Could we rebase the changes on top of master instead of merging?

@przepompownia przepompownia changed the base branch from shebang-handling to master November 6, 2019 20:59
Do not restrict it with this condition.
@przepompownia
Copy link
Author

TODO

  • review (I am beginner with TS-specific things)
  • allow to pass glob pattern in another way than using an environment variable
  • more tests
  • allow the user to disable scanning working dir against bash/sh shebang
  • give hasBashShebang only the first line of the file (do not match the entire content)

@skovhus
Copy link
Collaborator

skovhus commented Feb 27, 2020

Sorry for stalling here. I've investigated the issue, and it turns out that all bash files (that VS Code can detect) are handled just fine. We don't need to read all the files in a project–unless we want to do just to definition across files (required more work).

Screenshot 2020-02-27 10 41 54

Screenshot 2020-02-27 10 42 01

@przepompownia
Copy link
Author

It seemed to be natural that the results of analyzeing the rest of scripts are accessible for completion and jumping. Indeed: at the moment there is no need to make (almost?) unusable index.

@skovhus
Copy link
Collaborator

skovhus commented Mar 2, 2020

It seemed to be natural that the results of analyzeing the rest of scripts are accessible for completion and jumping. Indeed: at the moment there is no need to make (almost?) unusable index.

My mistake. It is indeed used for indexing. #47 (comment) 👍

@skovhus
Copy link
Collaborator

skovhus commented Mar 4, 2020

@przepompownia thanks for your work here. We now handle most of the cases here – except for reading all files.

I'm reluctant to implement parsing all the files in a project, that shouldn't be necessary. We might consider adding parsing all files without extensions though. :)

@skovhus skovhus closed this Mar 4, 2020
@przepompownia przepompownia deleted the shebang-handling branch March 4, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants