More file extensions than just "*.sh"?

[nwinkler]

It would be great if the user could provide more file extensions to parse. At the moment, only *.sh files are found and parsed:

https://github.com/mads-hartmann/bash-language-server/blob/00941c001ca342c8a9c1b647b2a1b7ea703e5fc6/server/src/analyser.ts#L47

When working with Bash scripts that use a different extension, e.g. .bash, the bash language server currently does not work.

It would be great if there was a configuration option that would allow to list the extensions that should be scanned...

[mads-hartmann]

@nwinkler This is a great idea. I'd be more than happy to merge a PR adding this feature 👍

[nwinkler]

It's been a while since I've done any Node.js/TypeScript, and I've never worked on an extension for VSCode, but that shouldn't stop me...

[nwinkler]

Found the developer guide - I'll take a look at that and see how far I can get. More time in the day would be nice...

[mads-hartmann]

@nwinkler Awesome 👏 Let me know if you have any questions

[Lucretia]

I also use .inc for include files. I'm not the only person who does this.

[bunam]

add .command on mac ?

i think a better solution is to look in the 1st line for began by '#!' and containing 'bash' 'sh' ... ?
#!/usr/bin/env bash

[maximbaz]

Or rely on mime type, as that one already respects shebang and all possible file extensions:

❯ file --mime-type $(readlink -m ~/bin/backup)
text/x-shellscript

Example with readlink may not be cross-platform, I just wanted to point out that symlinks need to be correctly handled.

[skovhus]

Good point with the symlinks @maximbaz

Any PRs would be much appreciated.

[skovhus]

So we have two use cases:

1. files without .sh extensions that are bash scripts
2. file with .sh extensions that are not bash scripts

Suggested solution: Read the shebang line for all potential shell script files (.sh, .command, .inc, and no file extension).

As a nice to have on top, we should make the glob pattern configurable.