Skip to content

[WIP] More file extensions than .sh and shebang lookup #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Mar 23, 2019

This allows more file extensions than just .sh. Besides, we limit the files being analyzed to the ones that have a bash / sh shebang.

While doing this, I was able to remove some of the fs.existsSync and fs.lstatSync lookups, that would be done directly in glob.

I also tried fast-glob, but the matching algorithm didn't seem that stable (although a lot faster).

To support file names without file extensions, we probably need another glob glob.sync('**/!(*.*)').

Related: #47

@skovhus
Copy link
Collaborator Author

skovhus commented Mar 2, 2020

Replaced by #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant