Update tests for dependencies #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originaly, `import 'mocha’` was added to satisfy Typescript. But this made `webpack` include all of `mocha` in the bundle. Karma was starting to run out of memory when processing all the test files.
The config was in a tenuous state functioning. Changing the config to the root Typescript config file that references each module, and enabling projectReferences make the configuration explicit. Also adding a log for errors such as when AWS credentials are not available makes this error much more obvious.
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When `lerna link` was run, in aws#242 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. Finally, update `local_verdaccio_publish` to not reset package-lock.json files as they do not exist.
scottarc
approved these changes
Apr 1, 2020
| @@ -16,7 +16,7 @@ | |||
| /* eslint-env mocha */ | |||
|
|
|||
| import { expect } from 'chai' | |||
| import 'mocha' | |||
| // import 'mocha' | |||
There was a problem hiding this comment.
In most other files, this import was deleted. In this file, it was commented out.
| @@ -18,7 +18,7 @@ | |||
| import * as chai from 'chai' | |||
| import chaiAsPromised from 'chai-as-promised' | |||
| import sinon from 'sinon' | |||
| import 'mocha' | |||
| // import 'mocha' | |||
There was a problem hiding this comment.
This was also commented out instead of deleted.
seebees
added a commit
to seebees/aws-sdk-js-crypto-helpers-1
that referenced
this pull request
Apr 6, 2020
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When lerna link was run, in aws#27 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. This is similar to aws/aws-encryption-sdk-javascript#285 # Conflicts: # package-lock.json # packages/crc32/package-lock.json # packages/ie11-detection/package-lock.json # packages/random-source-browser/package-lock.json # packages/random-source-node/package-lock.json # packages/random-source-universal/package-lock.json # packages/sha256-browser/package-lock.json # packages/sha256-js/package-lock.json # packages/sha256-universal/package-lock.json # packages/supports-web-crypto/package-lock.json
seebees
added a commit
to seebees/aws-sdk-js-crypto-helpers-1
that referenced
this pull request
Apr 6, 2020
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When lerna link was run, in aws#27 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. This is similar to aws/aws-encryption-sdk-javascript#285
seebees
added a commit
to aws/aws-sdk-js-crypto-helpers
that referenced
this pull request
Apr 6, 2020
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When lerna link was run, in #27 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. This is similar to aws/aws-encryption-sdk-javascript#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to deal with version updates failing tests.
The tests were passing, Karma was starting to see errors,
both on Typescript compile and on the size of the bundle.
First: Remove mocha import to shrink bundle
Originally,
import 'mocha’was added to satisfy Typescript.But this made
webpackinclude all ofmochain the bundle.Karma was starting to run out of memory when processing all the test files.
Second: update karma config
The config was in a tenuous state functioning.
Changing the config to the root Typescript config file
that references each module,
and enabling projectReferences make the configuration explicit.
Also adding a log for errors
such as when AWS credentials are not available
makes this error much more obvious.
Third: update dependency versions
This is an explicit update to versions.
Additionally all sub modules package-lock.json files are removed.
When
lerna linkwas run, in #242all modules were linked together at the root.
This means that the root package-lock.json file is responsible
for all sub modules state.
Lerna does not maintain the state on these modules package-lock.json anymore.
So this information is redundant.
Finally, update
local_verdaccio_publishto not reset package-lock.json files as they do not exist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: