chore: Prep for dependabot #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lerna link convert` This links all the packages to the root and removed the need for `lerna bootstrap` This moves all the `devDependencies` from the individual `package.json` files to the root, and links the internal modules together. This does make things complicated for `integration-browser` and `integration-node` because these files compile the TS to JS for a CLI. But this JS file does not exists because it is build from the Typescript. So there is a chicken/egg situation where the file needs to exists to be installed, but the file needs to be built. I added a hack to `touch` the file when the monorepo is built. This should help with dependabot PRs as well as making `npm audit` just work.
scottarc
approved these changes
Feb 17, 2020
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this pull request
Apr 1, 2020
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When `lerna link` was run, in aws#242 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. Finaly, update `local_verdaccio_publish` to not reset package-lock.json files as they do not exist.
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this pull request
Apr 1, 2020
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When `lerna link` was run, in aws#242 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. Finally, update `local_verdaccio_publish` to not reset package-lock.json files as they do not exist.
seebees
added a commit
that referenced
this pull request
Apr 1, 2020
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When `lerna link` was run, in #242 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. Finally, update `local_verdaccio_publish` to not reset package-lock.json files as they do not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lerna link convertThis links all the packages to the root
and removed the need for
lerna bootstrapThis moves all the
devDependenciesfrom the individualpackage.jsonfiles to the root,and links the internal modules together.
This does make things complicated
for
integration-browserandintegration-nodebecause these files compile the TS to JS for a CLI.
But this JS file does not exists because it is build from the Typescript.
So there is a chicken/egg situation where the file needs to exists to be installed,
but the file needs to be built.
I added a hack to
touchthe file when the monorepo is built.This should help with dependabot PRs
as well as making
npm auditjust work.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: