chore: add verdaccio publishing tests to CI #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottarc
reviewed
Mar 18, 2020
scottarc
previously approved these changes
Mar 18, 2020
resolves aws#123 To validate that everything always works, running the integration tests directly from npm will replicate exactly how customers would use this. It will also verify that all dependencies of the clients can be satisfied from npm. Finally, it exercises the publishing process to make sure that each release could be published automatically.
seebees
force-pushed
the
verdaccio-publish-tests
branch
from
bd9fc79 to
47b4a76
Compare
Add `--always-spawn` to npx command. This is **very** important, without this, npx may mask error codes. In testing it was possible to have errors in the npx command but the spawned process here did not exit with a non-zero exit code. See `execCommand` in `libnpx` for specifics
scottarc
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #123
To validate that everything always works,
running the integration tests directly from npm
will replicate exactly how customers would use this.
It will also verify that all dependencies of the clients
can be satisfied from npm.
Finally, it exercises the publishing process
to make sure that each release could be published automatically.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: