first cut better errorhandling

Author: seebees

util/local_verdaccio_publish

@@ -1,32 +1,55 @@
-#!/bin/bash
+#!/usr/bin/env node
+// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
 
-# Always clear storage so the latest versions are published
-# I am not worried about _what_ version number is published
-# Only that it is the latest code
-rm -rf verdaccio/storage/@aws-crypto
+// This is done in a node script for 2 reasons
+// 1. Potability: I will need to run this in windows
+// 2. Errors. If the main command fails, the script needs to clean up
+// but and exit with this error.
+// this _can_ be done from bash or shell,
+// but now the portability problems loom large.
 
-# Start verdaccio in the background
-verdaccio -c verdaccio/config.yaml &
+const { spawn, execSync } = require('child_process')
+const pipeStdIo = { stdio: [process.stdin, process.stdout, process.stderr] }
 
-# Publish all changed packages the local verdaccio server.
-# Anything that has not been changed will match what is in npm
-npx lerna publish prepatch \
-  --registry http://localhost:4873/ \
-  --yes \
-  --no-changelog \
-  --no-git-tag-version \
-  --no-push \
-  --no-git-reset \
-  --ignore-scripts \
-  --preid ci \
-  --no-verify-access
+// Always clear storage so the latest versions are published
+// I am not worried about _what_ version number is published
+// Only that it is the latest code
+execSync('rm -rf verdaccio/storage/@aws-crypto')
 
-# The above command will make some modifications,
-# Roll them back
-# Idealy, we would find a way to not have to do this
-git checkout -- modules/**/package-lock.json
-git checkout -- modules/**/package.json
+// Start verdaccio in the background
+const verdaccio = spawn('npx', ['verdaccio', '-c', 'verdaccio/config.yaml'], pipeStdIo)
+  .on('error', e => {
+    throw e
+  })
 
-# Kill everying
-# Especialy the background verdaccio server
-kill $(jobs -pr)
+// Publish all changed packages the local verdaccio server.
+// Anything that has not been changed will match what is in npm
+const args = [
+  'lerna', 'publish', 'prepatch',
+  '--registry', 'http://localhost:4873/',
+  '--yes',
+  '--no-changelog',
+  '--no-git-tag-version',
+  '--no-push',
+  '--no-git-reset',
+  '--ignore-scripts',
+  '--preid', 'ci',
+  '--no-verify-access'
+]
+spawn('npx', args, pipeStdIo)
+  .on('close', (code) => {
+    // The above command will make some modifications,
+    // Roll them back
+    // Ideally, we would find a way to not have to do this
+    execSync('git checkout -- modules/**/package-lock.json')
+    execSync('git checkout -- modules/**/package.json')
+
+    // Kill the background verdaccio server
+    verdaccio.kill()
+
+    // If this command had an error,
+    // we need to forward this.
+    // Otherwise the entire CI build may think that things succeeded.
+    if (code !== 0) throw Error(`Exit code: ${code}`)
+  })

util/npx_verdaccio

@@ -1,20 +1,50 @@
-#!/bin/bash
+#!/usr/bin/env node
+// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
 
-# I am assumeing that you used `local_verdaccio_publish`
-# But either way,
-# this is to facilitate running `npx`
-# and interacting with a local verdaccio server
-# So... I need a running server
-verdaccio -c verdaccio/config.yaml &
+// This is done in a node script for 2 reasons
+// 1. Potability: I will need to run this in windows
+// 2. Errors. If the main command fails, the script needs to clean up
+// but and exit with this error.
+// this _can_ be done from bash or shell,
+// but now the portability problems loom large.
 
-# run npx, and stuff an rc file that has _valid_ tokens
-# that match the local htpassword
+const { spawn } = require('child_process')
+const pipeStdIo = { stdio: [process.stdin, process.stdout, process.stderr] }
 
-npm_config_registry=http://localhost:4873/ npx \
-  --userconfig verdaccio/npmrc \
-  --ignore-existing \
-  "$@"
+// I am assuming that you used `local_verdaccio_publish`
+// But either way,
+// this is to facilitate running `npx`
+// and interacting with a local verdaccio server
+// So... I need a running server
+const verdaccio = spawn('npx', ['verdaccio', '-c', 'verdaccio/config.yaml'], pipeStdIo)
+  .on('error', e => {
+    throw e
+  })
 
-# Kill everying
-# Especialy the background verdaccio server
-kill $(jobs -pr)
+const args = [
+  '--userconfig', 'verdaccio/npmrc',
+  '--ignore-existing',
+  // Yes, this is dangerous.
+  // But I'm trying to replicate _just running npx_
+  // So if you get here, you should have had access to run npx anyway.
+  process.argv.slice(2)
+]
+
+spawn('npx', args, {
+    // This instance of npx needs to target the verdaccio server
+    // so the env var that governs this needs to be updated.
+    // it is _possible_ for this value to already be set.
+    // if the command has been executed from an npm script for example
+    env: { ...process.env, npm_config_registry: 'http://localhost:4873/'},
+    ...pipeStdIo
+  })
+  .on('close', (code) => {
+    // Kill the background verdaccio server
+    verdaccio.kill()
+
+    // If this command had an error,
+    // we need to forward this.
+    // Otherwise the entire CI build may think that things succeeded.
+    if (code !== 0) throw Error(`Exit code: ${code}`)
+  })