Skip to content

test: Condition tests for web-crypto-backend #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2019
Merged

test: Condition tests for web-crypto-backend #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c30ff
test: Condition tests for web-crypto-backend
seebees Jul 29, 2019
a15274f
Merge branch 'master' into conditions-web-crypto-backend
seebees Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion modules/web-crypto-backend/test/backend-factory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ import * as chai from 'chai'
import chaiAsPromised from 'chai-as-promised'
import sinon from 'sinon'
import 'mocha'
import { pluckSubtleCrypto, windowRequiresFallback, webCryptoBackendFactory } from '../src/backend-factory'
import {
pluckSubtleCrypto,
windowRequiresFallback,
webCryptoBackendFactory,
getNonZeroByteBackend,
getZeroByteSubtle
} from '../src/backend-factory'
import * as browserWindow from '@aws-sdk/util-locate-window'

import * as fixtures from './fixtures'
Expand Down Expand Up @@ -189,3 +195,25 @@ describe('webCryptoBackendFactory', () => {
})
})
})

describe('getNonZeroByteBackend', () => {
it('gets a subtle backend', () => {
const test = getNonZeroByteBackend(fixtures.subtleFallbackSupportsZeroByteGCM)
expect(test === fixtures.subtleFallbackSupportsZeroByteGCM.subtle).to.equal(true)
})

it('Precondition: A backend must be passed to get a non zero byte backend.', () => {
expect(() => getNonZeroByteBackend(false)).to.throw('No supported backend.')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a convenient way to make the meaning of the false more intuitive to the reader (e.g. by naming it, or adding a comment for what it does)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum... These functions operate on backends returned. I can add a comment. But the idea is that if a backend does not exist, I return false to be explicit. These helper functions are just handling that...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted about this offline and I can't think of a non-confusing way to express what I want here, so I would say let's just leave it.

})
})

describe('getZeroByteSubtle', () => {
it('gets a subtle backend', () => {
const test = getZeroByteSubtle(fixtures.subtleFallbackSupportsZeroByteGCM)
expect(test === fixtures.subtleFallbackSupportsZeroByteGCM.subtle).to.equal(true)
})

it('Precondition: A backend must be passed to get a zero byte backend.', () => {
expect(() => getZeroByteSubtle(false)).to.throw('No supported backend.')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

})
})