test: Condition tests for web-crypto-backend #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizroth
reviewed
Jul 31, 2019
| }) | ||
|
|
||
| it('Precondition: A backend must be passed to get a non zero byte backend.', () => { | ||
| expect(() => getNonZeroByteBackend(false)).to.throw('No supported backend.') |
There was a problem hiding this comment.
Is there a convenient way to make the meaning of the false more intuitive to the reader (e.g. by naming it, or adding a comment for what it does)?
There was a problem hiding this comment.
Hum... These functions operate on backends returned. I can add a comment. But the idea is that if a backend does not exist, I return false to be explicit. These helper functions are just handling that...
There was a problem hiding this comment.
We chatted about this offline and I can't think of a non-confusing way to express what I want here, so I would say let's just leave it.
| }) | ||
|
|
||
| it('Precondition: A backend must be passed to get a zero byte backend.', () => { | ||
| expect(() => getZeroByteSubtle(false)).to.throw('No supported backend.') |
lizroth
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: