-
Notifications
You must be signed in to change notification settings - Fork 63
feat: Encryption tests for integration-node #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
modules/integration-node/src/get_encrypt_test_iterator.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
/* | ||
* Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). You may not use | ||
* this file except in compliance with the License. A copy of the License is | ||
* located at | ||
* | ||
* http://aws.amazon.com/apache2.0/ | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
* implied. See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { | ||
EncryptManifestList, // eslint-disable-line no-unused-vars | ||
KeyList, // eslint-disable-line no-unused-vars | ||
KeyInfoTuple // eslint-disable-line no-unused-vars | ||
} from './types' | ||
import { randomBytes } from 'crypto' | ||
import { | ||
AlgorithmSuiteIdentifier, // eslint-disable-line no-unused-vars | ||
EncryptionContext // eslint-disable-line no-unused-vars | ||
} from '@aws-crypto/client-node' | ||
import { URL } from 'url' | ||
import { readFileSync } from 'fs' | ||
import got from 'got' | ||
|
||
export async function getEncryptTestVectorIterator (manifestFile: string, keyFile: string) { | ||
const { tests, plaintexts }: EncryptManifestList = await getParsedJSON(manifestFile) | ||
const { keys }: KeyList = await getParsedJSON(keyFile) | ||
|
||
const plaintextBytes: {[name: string]: Buffer} = {} | ||
|
||
Object | ||
.keys(plaintexts) | ||
.forEach(name => { | ||
plaintextBytes[name] = randomBytes(plaintexts[name]) | ||
}) | ||
|
||
return (function * nextTest (): IterableIterator<EncryptTestVectorInfo> { | ||
for (const [name, testInfo] of Object.entries(tests)) { | ||
const { | ||
plaintext, | ||
'master-keys': masterKeys, | ||
algorithm, | ||
'frame-size': frameLength, | ||
'encryption-context': encryptionContext | ||
} = testInfo | ||
const keysInfo = <KeyInfoTuple[]>masterKeys.map(keyInfo => { | ||
const key = keys[keyInfo.key] | ||
if (!key) throw new Error(`no key for ${name}`) | ||
return [keyInfo, key] | ||
}) | ||
|
||
/* I'm expecting that the encrypt function will throw if this is not a supported AlgorithmSuiteIdentifier */ | ||
const suiteId = <AlgorithmSuiteIdentifier>parseInt(algorithm, 16) | ||
|
||
yield { | ||
name, | ||
keysInfo, | ||
plainTextData: plaintextBytes[plaintext], | ||
encryptOp: { suiteId, frameLength, encryptionContext } | ||
} | ||
} | ||
})() | ||
} | ||
|
||
export interface EncryptTestVectorInfo { | ||
name: string, | ||
keysInfo: KeyInfoTuple[], | ||
plainTextData: Buffer, | ||
encryptOp: { | ||
suiteId: AlgorithmSuiteIdentifier, | ||
frameLength: number, | ||
encryptionContext: EncryptionContext | ||
} | ||
} | ||
|
||
async function getParsedJSON (thing: string) { | ||
try { | ||
const url = new URL(thing) | ||
if (url.protocol === 'file:') { | ||
return jsonAtPath(thing) | ||
} else { | ||
return jsonAtUrl(url) | ||
} | ||
} catch (ex) { | ||
return jsonAtPath(thing) | ||
} | ||
} | ||
async function jsonAtUrl (url: URL) { | ||
const { body } = await got(url) | ||
return JSON.parse(body) | ||
} | ||
|
||
function jsonAtPath (path: string) { | ||
const json = readFileSync(path, { encoding: 'utf-8' }) | ||
return JSON.parse(json) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to enumerate the vectors that are not supported? Right now, if something returns not supported, but should be, it would slip by. That being said, this can go into a new issue, and doesn't need to be fixed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is that what "tolerateFailures" does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tolerateFailures is just a count of failures to tolerate. CI should be 0.
Your comment is true. The hope is to come up with a results manifest. That could be compared and determine success.