feat: Encryption tests for integration-node #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/awslabs/aws-crypto-tools-test-vector-framework defines an encryption manifest. This manifest should be used to maintain cross compatibility of language implementations. Then integrate this into the CI integration tests.
karlw00t
reviewed
Jul 19, 2019
| if (result) { | ||
| console.log({ name, result }) | ||
| } else { | ||
| if (err && notSupportedDecryptMessages.includes(err.message)) { |
There was a problem hiding this comment.
Do we want to enumerate the vectors that are not supported? Right now, if something returns not supported, but should be, it would slip by. That being said, this can go into a new issue, and doesn't need to be fixed here.
There was a problem hiding this comment.
or is that what "tolerateFailures" does?
There was a problem hiding this comment.
tolerateFailures is just a count of failures to tolerate. CI should be 0.
Your comment is true. The hope is to come up with a results manifest. That could be compared and determine success.
karlw00t
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/awslabs/aws-crypto-tools-test-vector-framework defines an encryption manifest.
This manifest should be used to maintain cross compatibility of language implementations.
Then integrate this into the CI integration tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.