Skip to content

chore(tests): revert change timeout reporting in idempotency e2e tests #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

Important

This PR reverts #2074

After running more tests it appears that the changes introduced in #2074 were not necessary, so we I am reverting them.

Related issues, RFCs

Issue number: #2076

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Feb 16, 2024
@dreamorosi dreamorosi requested a review from a team February 16, 2024 11:37
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Feb 16, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Feb 16, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
42.9% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi
Copy link
Contributor Author

Integration tests running successfully on this branch: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/7930014005

@dreamorosi dreamorosi requested review from sthulb and am29d February 16, 2024 11:51
@am29d am29d merged commit 36e3e62 into main Feb 16, 2024
@am29d am29d deleted the revert-2074-chore/idempotency/tests branch February 16, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants