chore(tests): change timeout reporting in idempotency e2e tests #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
do-not-merge
2 tasks
dreamorosi
removed
do-not-merge
|
sthulb
approved these changes
Feb 16, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR makes slight changes to the integration test cases that assert the behavior of the Idempotency utility in the event of Lambda timeouts.
The implementation of the utility hasn't changed, but in the tests we are now expecting a different number of logs as well as a different message for functions that timeout.
I am not 100% sure about why, also because I can't test the old behavior, but it seems that Lambda functions timing out now return a different number of logs when invoked API. This resembles changes that were made by the new-ish Advanced Logging Configuration feature by Lambda, but as I said I'm not entirely sure.
Given that the implementation is the same and the changes are not on our side nor in our tests but rather in the way Lambda logs a timeout event, I decided to not investigate further and use the time elsewhere.
Related issues, RFCs
Issue number: #2076
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.