improv: override Tracer auto-capture response/exception via env vars #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #259 +/- ##
===========================================
- Coverage 99.81% 99.74% -0.08%
===========================================
Files 76 78 +2
Lines 2763 2777 +14
Branches 113 114 +1
===========================================
+ Hits 2758 2770 +12
- Misses 4 5 +1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
heitorlessa
changed the title
heitorlessa
changed the title
nmoutschen
reviewed
Jan 13, 2021
|
Addressed all your comments and some other oversights I've noticed too - Here's the doc too. Over to you @nmoutschen
|
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jan 17, 2021
* develop: chore: move env names to constant file (#264) docs: fix import (#267) feat: Add AppConfig parameter provider (#236) chore: update stale bot improv: override Tracer auto-capture response/exception via env vars (#259) docs: add info about extras layer (#260) feat: support extra parameter in Logger messages (#257) chore: general simplifications and cleanup (#255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Feature parity with Java powertools PR aws-powertools/powertools-lambda-java#249
Description of changes:
Adds env var support to override default behaviour in Tracer of auto-capturing both response and error:
"true", "True", "TRUE")"true", "True", "TRUE")Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.