Skip to content

feat: support for env variable in tracing capture modes #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented Jan 12, 2021

Issue #, if available:

Description of changes:

closes #231

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

msailes
msailes previously approved these changes Jan 12, 2021
Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@pankajagrawal16 pankajagrawal16 force-pushed the tracing-caputre-modes branch 3 times, most recently from ca8368e to 0d3879d Compare January 12, 2021 14:45
msailes
msailes previously approved these changes Jan 12, 2021
Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, ship it!

Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@pankajagrawal16 pankajagrawal16 merged commit 3a0cd5e into master Jan 12, 2021
@pankajagrawal16 pankajagrawal16 deleted the tracing-caputre-modes branch January 12, 2021 14:53
@heitorlessa
Copy link
Contributor

late to the game, could we please ensure env vars follow the project name so it's clearer for customers when using multiple 3rd party libs?

e.g. POWERTOOLS_TRACER_CAPTURE_RESPONSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default values for tracing utilty parameters
3 participants