Skip to content

Changed operator bool to explicit rather than implicit conversion in Serial #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Changed operator bool to explicit rather than implicit conversion in Serial #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/arduino/UART.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class UartClass : public HardwareSerial
inline size_t write(unsigned int n) { return write((uint8_t)n); }
inline size_t write(int n) { return write((uint8_t)n); }
using Print::write; // pull in write(str) and write(buf, size) from Print
operator bool() { return true; }
explicit operator bool() { return true; }

// Interrupt handlers - Not intended to be called externally
inline void _rx_complete_irq(void);
Expand Down
2 changes: 1 addition & 1 deletion libraries/SoftwareSerial/src/SoftwareSerial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class SoftwareSerial : public Stream
virtual int read();
virtual int available();
virtual void flush();
operator bool() { return true; }
explicit operator bool() { return true; }

using Print::write;

Expand Down