Changed operator bool to explicit rather than implicit conversion in Serial #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file
SoftwareSerial.h and UART.h
If you were to notice that in every Serial based Class we have a function with the type
operator bool() { return true; }
By writing explicit, we can ensure that there is no form of implicit conversion or otherwise.
For further details view https://stackoverflow.com/questions/39995573/when-can-i-use-explicit-operator-bool-without-a-cast
This would ensure that
bool b = Serial1;
would not result in b getting a valueFor example, comparing the following codes:-
Does not result in an error due to an absence of explicit.
However, adding explicit we get an error that the conversion cannot be performed in the following sample.
An Operator bool with explicit would render it compatible with only these statements
For example
CONSTEXPR
Further, I have marked these statements as
constexpr
given they indeed are constant compile time expressions and their values will not change dynamically at runtime