NBConnectionHandler: fix constructor chaining #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlbyIanna @mastrolinux please test. |
mastrolinux
approved these changes
Jan 7, 2020
@sandeepmistry While I haven't merged the PR you mention I'd like to point out that I can't test any NB1500 stuff at my location and that's not for a lack of trying - simply no 5G coverage. |
|
I tested it with a Vodafone SIM and worked for me. I am not able to test it with a APN, login, and pass though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issues with the long constructor added in #12.
It appears PR #12 was merged without testing, this is very bad.
cc/ @AlbyIanna