Add overloaded constructors for optional apn, login and pass in NBConnectionHandler #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbyIanna
force-pushed
the
AlbyIanna/NBConnectionHandler-optional-values
branch
from
cec6740 to
0e1c597
Compare
src/Arduino_NBConnectionHandler.cpp
Outdated
| @@ -113,7 +123,7 @@ void NBConnectionHandler::update() { | |||
| case NetworkConnectionState::CONNECTING: { | |||
| // NOTE: Blocking Call when 4th parameter == true | |||
| NB_NetworkStatus_t networkStatus; | |||
| networkStatus = gprs.attachGPRS(); | |||
| networkStatus = gprs.attachGPRS(apn, login, pass, true); | |||
There was a problem hiding this comment.
I don't see a default value for apn, login, or pass do they default to NULL or empty string?
There was a problem hiding this comment.
not sure, but I think they're NULL
There was a problem hiding this comment.
I highly recommend they be explicitly initialized.
There was a problem hiding this comment.
How would you initialize those values? Can I do that in the signature?
There was a problem hiding this comment.
Also I don’t think this compiles, here is the signature: https://github.com/arduino-libraries/MKRNB/blob/master/src/GPRS.h#L58
The parameters should be passed to ‘nbAccess.begin(...)’.
AlbyIanna
force-pushed
the
AlbyIanna/NBConnectionHandler-optional-values
branch
from
0e1c597 to
8501341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.