Code

TimeService update/refactor#318

Code

Closed

pennam wants to merge 20 commits intoarduino-libraries:masterarduino-libraries/ArduinoIoTCloud:masterfrom

pennam:time_service_updatepennam/ArduinoIoTCloud:time_service_updateCopy head branch name to clipboard

Commits

Commits on May 24, 2022

• TimeService: Add connected() method to check connection status

  pennam

  committed
  956de5a

  Copy full SHA for 956de5a

• Check if board is connected before trying to get time from network/NTP

  pennam

  committed
  398bef8

  Copy full SHA for 398bef8

• Add HAS_RTC define in config file for boards with RTC support

  pennam

  committed
  4f79884

  Copy full SHA for 4f79884

• Fix includes to make HAS_RTC macro available in TimeService code

  pennam

  committed
  bd8ec23

  Copy full SHA for bd8ec23

• Add internal interface functions to RTC

  pennam

  committed
  947c9c6

  Copy full SHA for 947c9c6

• Add getRTC() and configureRTC private methods

  pennam

  committed
  e837afb

  Copy full SHA for e837afb

• Use internal RTC interface function to initialize RTC hardware

  pennam

  committed
  ccc88de

  Copy full SHA for ccc88de

• TimeService::getTime rework to simplify logic

  Show description for c1d5a85
  pennam

  committed
  c1d5a85

  Copy full SHA for c1d5a85

• Fix isTimeValid() > EPOCH_AT_COMPILE_TIME

  Show description for 1f5722d
  pennam

  committed
  1f5722d

  Copy full SHA for 1f5722d

• Substitute missing build options with HAS_RTC define

  pennam

  committed
  4b7e17a

  Copy full SHA for 4b7e17a

• getRemoteTime() and connected() methods are meaningful only if TCP is available

  pennam

  committed
  8afe843

  Copy full SHA for 8afe843

• TimeService::setTimeZoneData: change timezone prints from DEBUG_DEBUG to DEBUG_VERBOSE

  pennam

  committed
  52f19f6

  Copy full SHA for 52f19f6

• TimeService::setTimeZoneData: add braces around single statement if

  pennam

  committed
  0f3511a

  Copy full SHA for 0f3511a

• TimeService::setTimeZoneData print timezone updates in one row

  pennam

  committed
  2597a79

  Copy full SHA for 2597a79

• TimeService: other cosmetics changes

  pennam

  committed
  6c7b163

  Copy full SHA for 6c7b163

Commits on May 25, 2022

• Fix debug prints reporting the wrong class name

  pennam

  committed
  5bbec58

  Copy full SHA for 5bbec58

• Make explicit that timezone support is not available for devices without TCP connection

  pennam

  committed
  4ea05aa

  Copy full SHA for 4ea05aa

• Fix getTime() flow and add comments to describe it

  pennam

  committed
  2d7c0cf

  Copy full SHA for 2d7c0cf

• Rename TimeService into TimeServiceClass and use a more standard way to instantiate it

  pennam

  committed
  e9e0434

  Copy full SHA for e9e0434

• Fix build for esp8226

  pennam

  committed
  5132d2b

  Copy full SHA for 5132d2b