Skip to content

TimeService update/refactor #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

TimeService update/refactor #318

wants to merge 20 commits into from

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented May 25, 2022

After #317 and #302 i thought to cleanup TimeService class before proceeding with other developments.

pennam added 20 commits May 24, 2022 11:24
@pennam
TimeService: Add connected() method to check connection status
956de5a
@pennam
Check if board is connected before trying to get time from network/NTP
398bef8
@pennam
Add HAS_RTC define in config file for boards with RTC support
4f79884
@pennam
Fix includes to make HAS_RTC macro available in TimeService code
bd8ec23
@pennam
Add internal interface functions to RTC
947c9c6
@pennam
Add getRTC() and configureRTC private methods
e837afb
@pennam
Use internal RTC interface function to initialize RTC hardware
ccc88de
@pennam
TimeService::getTime rework to simplify logic
c1d5a85 
  If board has RTC use getRTC() to retrive time, otherwise always use getRemoteTime()
  Check for valid time before return, if not valid return EPOCH_AT_COMPILE_TIME
@pennam
Fix isTimeValid() > EPOCH_AT_COMPILE_TIME
1f5722d 
  TCP  BOARDS: During RTC configuration we don't want to store EPOCH_AT_COMPILE_TIME into RTC register otherwise internal time will be wrong and scheduler wont work.
  LORA BOARDS: This check is not performed for LORA BOARDS since we don't have a valid timesource
@pennam
Substitute missing build options with HAS_RTC define
4b7e17a
@pennam
getRemoteTime() and connected() methods are meaningful only if TCP is…
8afe843 
… available
@pennam
TimeService::setTimeZoneData: change timezone prints from DEBUG_DEBUG…
52f19f6 
… to DEBUG_VERBOSE
@pennam
TimeService::setTimeZoneData: add braces around single statement if
0f3511a
@pennam
TimeService::setTimeZoneData print timezone updates in one row
2597a79
@pennam
TimeService: other cosmetics changes
6c7b163
@pennam
Fix debug prints reporting the wrong class name
5bbec58
@pennam
Make explicit that timezone support is not available for devices with…
4ea05aa 
…out TCP connection
@pennam
Fix getTime() flow and add comments to describe it
2d7c0cf
@pennam
Rename TimeService into TimeServiceClass and use a more standard way …
e9e0434 
…to instantiate it
@pennam
Fix build for esp8226
5132d2b
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 25, 2022
@github-actions
Copy link

Memory usage change @ 5132d2b

Board flash % RAM for global variables %
arduino:mbed:envie_m7 ❔ -80 - +80 -0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +98 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision ❔ -80 - +144 -0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 ❔ -8 - +136 -0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 ❔ -8 - +136 -0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 +72 - +80 +0.03 - +0.03 💚 -8 - -8 -0.02 - -0.02
arduino:samd:mkrwifi1010 ❔ -8 - +136 -0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot ❔ -8 - +136 -0.0 - +0.05 0 - 0 0.0 - 0.0
esp32:esp32:esp32 💚 -892 - -872 -0.07 - -0.07 💚 -32 - -32 -0.01 - -0.01
esp8266:esp8266:huzzah 💚 -188 - -172 -0.02 - -0.02 💚 -132 - -112 -0.16 - -0.14
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:mbed:envie_m7 -80 -0.01 0 0.0 -8 -0.0 0 0.0 -72 -0.01 0 0.0 80 0.01 0 0.0
arduino:mbed_nano:nanorp2040connect 44 0.0 0 0.0 44 0.0 0 0.0 44 0.0 0 0.0 98 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision -80 -0.01 0 0.0 -16 -0.0 0 0.0 -16 -0.0 0 0.0 144 0.02 0 0.0
arduino:samd:mkrgsm1400 -8 -0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 136 0.05 0 0.0
arduino:samd:mkrnb1500 -8 -0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 136 0.05 0 0.0
arduino:samd:mkrwan1300 80 0.03 -8 -0.02 72 0.03 -8 -0.02 72 0.03 -8 -0.02
arduino:samd:mkrwifi1010 -8 -0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 136 0.05 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot -8 -0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 136 0.05 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 -872 -0.07 -32 -0.01 -872 -0.07 -32 -0.01 -892 -0.07 -32 -0.01
esp8266:esp8266:huzzah -172 -0.02 -132 -0.16 -184 -0.02 -112 -0.14 -188 -0.02 -116 -0.14
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m7,-80,-0.01,0,0.0,-8,-0.0,0,0.0,-72,-0.01,0,0.0,80,0.01,0,0.0
arduino:mbed_nano:nanorp2040connect,44,0.0,0,0.0,44,0.0,0,0.0,44,0.0,0,0.0,98,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,-80,-0.01,0,0.0,-16,-0.0,0,0.0,-16,-0.0,0,0.0,144,0.02,0,0.0,,,,
arduino:samd:mkrgsm1400,-8,-0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,136,0.05,0,0.0,,,,
arduino:samd:mkrnb1500,-8,-0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,136,0.05,0,0.0,,,,
arduino:samd:mkrwan1300,80,0.03,-8,-0.02,72,0.03,-8,-0.02,72,0.03,-8,-0.02,,,,,,,,
arduino:samd:mkrwifi1010,-8,-0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,136,0.05,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,-8,-0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,136,0.05,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,-872,-0.07,-32,-0.01,-872,-0.07,-32,-0.01,-892,-0.07,-32,-0.01,,,,,,,,
esp8266:esp8266:huzzah,-172,-0.02,-132,-0.16,-184,-0.02,-112,-0.14,-188,-0.02,-116,-0.14,,,,,,,,

@pennam
Copy link
Collaborator Author

pennam commented Feb 16, 2023

superseded by #353

@pennam pennam closed this Feb 16, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 16, 2023
@pennam pennam deleted the time_service_update branch May 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pennam @per1234