-
Notifications
You must be signed in to change notification settings - Fork 81
Add Uno WiFi Rev2 to "Compile Examples" CI workflow #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uno WiFi Rev2 to "Compile Examples" CI workflow #209
Conversation
I don't know enough about this code to determine whether the errors are legitimate or caused by a bad workflow configuration:
Please let me know if any changes are needed. |
Memory usage change @ 34ec8ad
Click for full report table
Click for full report CSV
|
I removed it to make all prints no-op and thus saving flash. Not sure if there's a better way since it seems that DBG_* is declared both here https://github.com/arduino-libraries/ArduinoIoTCloud/blob/master/src/AIoTC_Config.h#L33-L51 as a define and here https://github.com/arduino-libraries/Arduino_DebugUtils/blob/master/src/Arduino_DebugUtils.h#L33 as a constant. |
Wow, that's a good catch. I'm surprised those definitions didn't bite themselves yet. However, disabling all debug (and error output) across the whole library seems unfavourable to me. I'm wondering how you safely disabled debug output for AVR while keeping it safely enabled for all other platforms? |
@aentinger this kicks in only for the uno wifi r2, and since the only other API excluding DBG* macros is |
I see now the problem. It's missing it's constants. Let me do a bit of cleanup altogether, I'm not too happy with this quick and dirty solution. |
All |
OK, rebase is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you @per1234 🚀
No description provided.