Skip to content

Add Uno WiFi Rev2 to "Compile Examples" CI workflow #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add Uno WiFi Rev2 to "Compile Examples" CI workflow #209

merged 1 commit into from
Nov 18, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 17, 2020

No description provided.

@per1234
Copy link
Contributor Author

per1234 commented Nov 17, 2020

I don't know enough about this code to determine whether the errors are legitimate or caused by a bad workflow configuration:

https://github.com/arduino-libraries/ArduinoIoTCloud/pull/209/checks?check_run_id=1411570685#step:9:82

  In file included from /github/home/Arduino/libraries/ArduinoIoTCloud/src/ArduinoIoTCloud.h:152:0,
                   from /tmp/arduino-sketch-0CD64181F5310E3579165DCB549C8EEE/sketch/thingProperties.h:1,
                   from /github/workspace/examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino:14:
  /github/home/Arduino/libraries/ArduinoIoTCloud/src/ArduinoIoTCloudTCP.h: At global scope:
  /github/home/Arduino/libraries/ArduinoIoTCloud/src/ArduinoIoTCloudTCP.h:111:5: error: 'WiFiBearSSLClient' does not name a type; did you mean 'WiFiSSLClient'?
       WiFiBearSSLClient _sslClient;
       ^~~~~~~~~~~~~~~~~
       WiFiSSLClient

https://github.com/arduino-libraries/ArduinoIoTCloud/pull/209/checks?check_run_id=1411570685#step:9:121

  /github/workspace/examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino: In function 'void setup()':
  /github/workspace/examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino:27:32: error: too few arguments to function 'void setDebugMessageLevel(int)'
     setDebugMessageLevel(DBG_INFO);
                                  ^
  In file included from /tmp/arduino-sketch-0CD64181F5310E3579165DCB549C8EEE/sketch/thingProperties.h:1:0,
                   from /github/workspace/examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino:14:
  /github/home/Arduino/libraries/ArduinoIoTCloud/src/ArduinoIoTCloud.h:158:6: note: declared here
   void setDebugMessageLevel(int const level);
        ^~~~~~~~~~~~~~~~~~~~

Please let me know if any changes are needed.

@github-actions
Copy link

Memory usage change @ 34ec8ad

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
%
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp8266:esp8266:huzzah 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,

@aentinger
Copy link
Contributor

Hi @per1234 👋
The 1st error concerning WiFiBearSSLClient is to be expected, since there is a pending PR here.
The 2nd error I'm not sure. I've seen that @facchinm removed Arduino_DebugUtils for the Uno WiFi Rev. 2 port, @facchinm why?

@facchinm
Copy link
Contributor

I removed it to make all prints no-op and thus saving flash. Not sure if there's a better way since it seems that DBG_* is declared both here https://github.com/arduino-libraries/ArduinoIoTCloud/blob/master/src/AIoTC_Config.h#L33-L51 as a define and here https://github.com/arduino-libraries/Arduino_DebugUtils/blob/master/src/Arduino_DebugUtils.h#L33 as a constant.
I'd advise to change one of the two since right now it's very confusing.

@aentinger
Copy link
Contributor

Wow, that's a good catch. I'm surprised those definitions didn't bite themselves yet. However, disabling all debug (and error output) across the whole library seems unfavourable to me. I'm wondering how you safely disabled debug output for AVR while keeping it safely enabled for all other platforms?

@facchinm
Copy link
Contributor

@aentinger this kicks in only for the uno wifi r2, and since the only other API excluding DBG* macros is setDebugLevel I implemented it here (0d47fbd#diff-4a6e083fb52e51c32948055d546936cdf5da314a3bf3f59a8117a167289ba6f2R183 , weak)

@aentinger
Copy link
Contributor

I see now the problem. It's missing it's constants. Let me do a bit of cleanup altogether, I'm not too happy with this quick and dirty solution.

@aentinger
Copy link
Contributor

All Arduino_DebugUtils related worries should have been taken care of with release of 0.5.1. Also a couple of commits have been made to https://github.com/arduino-libraries/ArduinoIoTCloud/tree/offload-ssl-nina-take2 . May I ask @per1234 to rebase this PR?

@per1234
Copy link
Contributor Author

per1234 commented Nov 18, 2020

OK, rebase is done.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @per1234 🚀

@aentinger aentinger merged commit bd8ce31 into arduino-libraries:offload-ssl-nina-take2 Nov 18, 2020
@per1234 per1234 deleted the offload-ssl-nina-take2-workflow-update branch November 18, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants