Use sketch compilation CI actions from their new dedicated repositories #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "smoke test" sketch compilation and reporting actions have been moved to dedicated repositories. The actions hosted at the old `arduino/actions/libraries/*` location will no longer be maintained. Since the time the actions were migrated to the dedicated repositories, a breaking change was made to the default value of the `sketches-report-path` input, which required a change to the values of the `name` and `path` inputs of the `actions/upload-artifact` action.
The reliance on the `actions/upload-artifacts` action means that these values will always be hardcoded into the workflow. The result is that if the default values of the inputs are changed, it breaks the workflow, even if the changes are synchronized. So it's safest to not rely on the defaults.
Since the time the "Compile Examples" workflow was written, some improvements have been made to the API of the `arduino/compile-sketches` CI action. The previous API is still supported, but is deprecated and warnings are displayed in the workflow run log about this, which could result in confusion for contributors.
|
Can/Should we merge this one due to #209? I'm wondering how much they double in functionality. |
|
There's no doubled functionality. Either one will cause a merge conflict in the other, but it will be easy enough to rebase. Even though the deltas report workflows are failing, the deltas reports are still being made (because the action is processing the new CI runs before hitting the expired one and breaking), so the bug in the old action isn't really causing any problems other than perhaps confusing someone if they look at the actions tab and see all those ugly ❌ . So there's no rush in merging this. |
aentinger
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "smoke test" sketch compilation and reporting actions have been moved to dedicated repositories. The actions hosted at the old
arduino/actions/libraries/*location will no longer be maintained.Since the time the actions were migrated to the dedicated repositories, a breaking change was made to the default value of the
sketches-report-pathinput, which required a change to the values of thenameandpathinputs of theactions/upload-artifactaction.Since the time the "Compile Examples" workflow was written, some improvements have been made to the API of the
arduino/compile-sketchesCI action. The previous API is still supported, but is deprecated and warnings are displayed in the workflow run log about this, which could result in confusion for contributors.GitHub only runs scheduled workflows that are in the repository's default branch. This means that the changes made in this PR to the report size deltas workflow will not take effect until the PR is merged. However, the changes to the "Compile Examples" workflow will take effect immediately. The workflow artifact created by the Compile Examples workflow is now named "sketches-reports", but the artifact name the previous report size deltas workflow running in the
masterbranch looks for is "size-deltas-reports". This means there will be no size deltas report comment on this PR, but after it is merged the size deltas report comments will resume as usual.This PR fixes the failing report size deltas workflow (e.g., https://github.com/arduino-libraries/ArduinoIoTCloud/actions/runs/366203792), which is caused by a bug that was only fixed in the new
arduino/report-size-deltasaction repository. (the motivation for this PR)