Skip to content

Fix redundant where clauses in AsyncBufferSequence extension #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix redundant where clauses in AsyncBufferSequence extension #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/AsyncAlgorithms/AsyncBufferSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,8 @@ public struct AsyncBufferSequence<Base: AsyncSequence, Buffer: AsyncBuffer> wher
}
}

extension AsyncBufferSequence: Sendable where Base: Sendable, Base.AsyncIterator: Sendable, Base.Element: Sendable { }
extension AsyncBufferSequence.Iterator: Sendable where Base: Sendable, Base.AsyncIterator: Sendable, Base.Element: Sendable { }
extension AsyncBufferSequence: Sendable where Base: Sendable { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperryua do you think we should just make AsyncBufferSequence require the Base to be Sendable and avoid this type of thing?

Copy link
Contributor Author

@TiagoMaiaL TiagoMaiaL Apr 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, the warnings are specific to the Base.Element: Sendable constraint. I took the liberty to also remove the Base.AsyncIterator constraint as well.

The declaration of AsyncBufferSequence already defines them:

public struct AsyncBufferSequence<Base: AsyncSequence, Buffer: AsyncBuffer> where Base.Element == Buffer.Input, Base.AsyncIterator: Sendable { /* ... */  }
  • It contains an explicit AsyncIterator constraint.
  • Base.Element must be Buffer.Input (aka AsyncBuffer.Input), which is already Sendable (line 130).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original intention here was to fully specify all the requirements here, knowing that these would be redundant, to make it eaiser for the reader to discover the full Sendable requirements. For some reason, even now, I'm not seeing Xcode generate a warning for these. Could be a configuration different. I have no objection to appeasing the compiler here though. LGTM. Thank you!

extension AsyncBufferSequence.Iterator: Sendable where Base: Sendable { }

extension AsyncBufferSequence: AsyncSequence {
public typealias Element = Buffer.Output
Expand Down