Fix redundant where clauses in AsyncBufferSequence extension
#141
Conversation
| @@ -234,8 +234,8 @@ public struct AsyncBufferSequence<Base: AsyncSequence, Buffer: AsyncBuffer> wher | |||
| } | |||
| } | |||
|
|
|||
| extension AsyncBufferSequence: Sendable where Base: Sendable, Base.AsyncIterator: Sendable, Base.Element: Sendable { } | |||
| extension AsyncBufferSequence.Iterator: Sendable where Base: Sendable, Base.AsyncIterator: Sendable, Base.Element: Sendable { } | |||
| extension AsyncBufferSequence: Sendable where Base: Sendable { } | |||
There was a problem hiding this comment.
@kperryua do you think we should just make AsyncBufferSequence require the Base to be Sendable and avoid this type of thing?
There was a problem hiding this comment.
Just to be clear, the warnings are specific to the Base.Element: Sendable constraint. I took the liberty to also remove the Base.AsyncIterator constraint as well.
The declaration of AsyncBufferSequence already defines them:
public struct AsyncBufferSequence<Base: AsyncSequence, Buffer: AsyncBuffer> where Base.Element == Buffer.Input, Base.AsyncIterator: Sendable { /* ... */ }- It contains an explicit
AsyncIteratorconstraint. Base.Elementmust beBuffer.Input (aka AsyncBuffer.Input), which is alreadySendable(line 130).
There was a problem hiding this comment.
My original intention here was to fully specify all the requirements here, knowing that these would be redundant, to make it eaiser for the reader to discover the full Sendable requirements. For some reason, even now, I'm not seeing Xcode generate a warning for these. Could be a configuration different. I have no objection to appeasing the compiler here though. LGTM. Thank you!
Goal
To fix two warnings regarding redundant conformance constraints in
AsyncBufferSequence: