Skip to content

[FLINK-28574] Bump the JOSDK version to 3.2.1 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022
Merged

[FLINK-28574] Bump the JOSDK version to 3.2.1 #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ private void overrideOperatorConfigs(ConfigurationServiceOverrider overrider) {
} else {
LOG.info("Configuring operator with {} reconciliation threads.", parallelism);
overrider.withConcurrentReconciliationThreads(parallelism);
// feat: separate executor service for workflow
// https://github.com/java-operator-sdk/java-operator-sdk/pull/1371
overrider.withExecutorService(Executors.newFixedThreadPool(parallelism));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SteNicholas Could you please explain why we need this extra config here? Is it ok if we control it with the same config?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @csviri

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally only overrider.withConcurrentReconciliationThreads(parallelism); if you don't want to replace the executor service with a different flavor (thus other than a fixed thread pool).

see: https://github.com/java-operator-sdk/java-operator-sdk/blob/d9e869c3bf5319163d8d884529f6b4a926bd2d85/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java#L127-L129

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csviri @morhidi, this change comes from FlinkOperatorTest.java#L54, which get the ExecutorService with default thread number 10 and the concurrentReconciliationThreads() returns the default thread number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @csviri offline, he'll clarify this part in a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry, this seems to be an issue with the overrider, created a PR to fix it
operator-framework/java-operator-sdk#1484

pls for now override the service creation like above: overrider.withExecutorService

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morhidi, like @csviri mentioned, the current way that overrides the service creation is correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csviri, could the fix be released in 3.2.2? Otherwise I will remove this line when bumping the version to 4.0.0. cc @morhidi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteNicholas yes, will backport it to 3.x

}
if (configManager.getOperatorConfiguration().isJosdkMetricsEnabled()) {
overrider.withMetrics(new OperatorJosdkMetrics(metricGroup, configManager));
Expand Down
4 changes: 2 additions & 2 deletions flink-kubernetes-operator/src/main/resources/META-INF/NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ This project bundles the following dependencies under the Apache Software Licens
- io.fabric8:kubernetes-model-scheduling:5.12.3
- io.fabric8:kubernetes-model-storageclass:5.12.3
- io.fabric8:zjsonpatch:0.3.0
- io.javaoperatorsdk:operator-framework-core:3.1.1
- io.javaoperatorsdk:operator-framework:3.1.1
- io.javaoperatorsdk:operator-framework-core:3.2.1
- io.javaoperatorsdk:operator-framework:3.2.1
- org.apache.commons:commons-compress:1.21
- org.apache.commons:commons-lang3:3.12.0
- org.apache.commons:commons-math3:3.6.1
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ under the License.
<maven-resources-plugin.version>3.2.0</maven-resources-plugin.version>
<git-commit-id-maven-plugin.version>5.0.0</git-commit-id-maven-plugin.version>

<operator.sdk.version>3.1.1</operator.sdk.version>
<operator.sdk.version>3.2.1</operator.sdk.version>
<operator.sdk.admission-controller.version>0.2.0</operator.sdk.admission-controller.version>

<fabric8.version>5.12.3</fabric8.version>
Expand Down