Skip to content

fix: config service override executor service concurrent reconciliation numbers #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: config service override executor service concurrent reconciliation numbers #1484

merged 1 commit into from
Sep 19, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 19, 2022 •
edited
Loading

Fixes a bug that if only the number overwrite did not end up with correct executor service.

@csviri csviri added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2022
@csviri csviri self-assigned this Sep 19, 2022
@csviri csviri requested a review from metacosm September 19, 2022 12:00
@csviri csviri mentioned this pull request Sep 19, 2022
Merged
@csviri
Copy link
Collaborator Author

csviri commented Sep 19, 2022

cc @morhidi

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

56.2% 56.2% Coverage
0.0% 0.0% Duplication

metacosm
metacosm approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit a10d801 into main Sep 19, 2022
@csviri csviri deleted the config-service-override-fix branch September 19, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm