Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix: numerous responsive issues on screens from 360px to 960px #705

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jan 18, 2020

fix(component-sidenav): responsive issues w/ screens 720px to 960px width

  • close over sidenav on nav item selection

Fixes #686. Closes #687.

fix(docs-api): tables overflow screen width on mobile

  • fix docs-api layouts to work down to 360px width
    • fixes Observers, Accessibility, Drag and Drop, Platform, and Overlay layouts
  • fix DeprecatedconnectedTo to Deprecated connectedTo display issue
  • update footer copyright
  • fix exception trying to unsubscribe to undefined routeParamSubscription

Fixes #550

There is still an issue with the Datepicker Overview page, but that's an issue with https://github.com/angular/components/blame/dd4295608a9763518cd40b43b94059cc9c606fb4/src/material/datepicker/datepicker.md#L214-L218 rather than the docs site. That markdown table needs to be replaced with something that will work more responsively. This is fixed in PR angular/components#18210.

Screenshots

Before

Screen Shot 2020-01-18 at 07 39 18

After

Screen Shot 2020-01-18 at 07 39 10

@Splaktar Splaktar self-assigned this Jan 18, 2020
@Splaktar Splaktar changed the title fix: numerous responsive issues from screens from 360px to 960px fix: numerous responsive issues on screens from 360px to 960px Jan 18, 2020
@Splaktar Splaktar requested review from josephperrott and removed request for andrewseguin January 22, 2020 22:04
@josephperrott josephperrott removed their request for review January 23, 2020 17:15
@Splaktar Splaktar force-pushed the fix-toolbar-responsive branch 2 times, most recently from 295269e to 97a8d33 Compare January 26, 2020 23:48
@Splaktar Splaktar force-pushed the fix-toolbar-responsive branch from 97a8d33 to 6d1a377 Compare January 31, 2020 02:22
@Splaktar Splaktar requested a review from jelbourn January 31, 2020 02:28
…idth

- close over sidenav on nav item selection

Fixes #686. Closes #687.
- fix docs-api layouts to work down to 360px width
  - fixes Observers, Accessibility, Drag and Drop, Platform, and Overlay layouts
- fix DeprecatedconnectedTo to Deprecated connectedTo display issue
- update footer copyright
- fix exception trying to unsubscribe to undefined routeParamSubscription
- change how sidenav is closed on mobile after selecting a nav item

Fixes #550
@Splaktar Splaktar force-pushed the fix-toolbar-responsive branch from 6d1a377 to 12ee9b4 Compare January 31, 2020 16:53
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 987c17b into master Feb 4, 2020
@Splaktar Splaktar deleted the fix-toolbar-responsive branch February 5, 2020 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On some pages the header is not taking full width Mobile layout issues with some CDK pages
3 participants