Skip to content

docs(datepicker): convert date module tables to be mobile-friendly #18210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

Splaktar
Copy link
Contributor

  • remove instances of "just"

Fixes angular/material.angular.io#686

The 5 column markdown table added in PR #7837 causes responsive issues on most mobile devices.

Before

toolbar responsive issue screenshot

@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround docs This issue is related to documentation target: major This PR is targeted for the next major release labels Jan 18, 2020
@Splaktar Splaktar added this to the 9.0.0 milestone Jan 18, 2020
@Splaktar Splaktar self-assigned this Jan 18, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 18, 2020
@Splaktar Splaktar added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jan 20, 2020
@Splaktar Splaktar requested a review from jelbourn January 26, 2020 22:47
@Splaktar Splaktar force-pushed the fix-datepicker-responsive-overview branch from 6d5f27a to 71c22f2 Compare January 26, 2020 23:56
@jelbourn jelbourn removed this from the 9.0.0 milestone Jan 28, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 28, 2020
@jelbourn jelbourn merged commit 6ef58a2 into master Jan 28, 2020
@Splaktar Splaktar deleted the fix-datepicker-responsive-overview branch January 29, 2020 04:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On some pages the header is not taking full width
3 participants