fix(list): fix role for list-item #8767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinayuangao
requested review from
crisbeto,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
crisbeto
reviewed
Dec 1, 2017
src/lib/list/list.ts
Outdated
| @@ -134,6 +134,7 @@ export class MatListItem extends _MatListItemMixinBase implements AfterContentIn | |||
| CanDisableRipple { | |||
| private _lineSetter: MatLineSetter; | |||
| private _isNavList: boolean = false; | |||
| role: string | null = null; | |||
There was a problem hiding this comment.
Shouldn't this one be underscored?
There was a problem hiding this comment.
Done. Thanks for review
tinayuangao
force-pushed
the
fix-list-a11y
branch
from
8728ed7 to
63a04b4
Compare
crisbeto
added
pr: lgtm
action: merge
tinayuangao
force-pushed
the
fix-list-a11y
branch
3 times, most recently
from
bfec9b6 to
805275e
Compare
tinayuangao
force-pushed
the
fix-list-a11y
branch
from
805275e to
4c19bc6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role for
mat-list-itemshould not be set. User ofmat-list-itemshould set the role.