Skip to content

Commit 8f7c7cf

Browse files
authored
fix(list): fix role for list-item (#8767)
1 parent 5210b3e commit 8f7c7cf

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

src/demo-app/a11y/list/list-a11y.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<h2> Seasoning </h2>
44
<p>Showing a non-interactive list of seasonings.</p>
55
<mat-list role="list">
6-
<mat-list-item *ngFor="let item of items"> {{item}} </mat-list-item>
6+
<mat-list-item role="listitem" *ngFor="let item of items"> {{item}} </mat-list-item>
77
</mat-list>
88
</section>
99

@@ -26,7 +26,7 @@ <h2>Messages</h2>
2626
message subject, and content of the message.
2727
</p>
2828
<mat-list role="list">
29-
<mat-list-item *ngFor="let message of messages">
29+
<mat-list-item role="listitem" *ngFor="let message of messages">
3030
<img mat-list-avatar [src]="message.image" [alt]="message.from">
3131
<h3 mat-line> {{message.from}} </h3>
3232
<p mat-line> {{message.subject}} </p>
@@ -39,8 +39,8 @@ <h3 mat-line> {{message.from}} </h3>
3939
<section>
4040
<h2>Seasoning</h2>
4141
<p>Showing a non-interactive list of seasonings with dense style.</p>
42-
<mat-list dense>
43-
<mat-list-item *ngFor="let item of items"> {{item}} </mat-list-item>
42+
<mat-list role="list" dense>
43+
<mat-list-item role="listitem" *ngFor="let item of items"> {{item}} </mat-list-item>
4444
</mat-list>
4545
</section>
4646

@@ -49,14 +49,14 @@ <h2>Folders and notes for mailbox </h2>
4949
<p>Showing a list with two sections, "folders" and "notes".</p>
5050
<mat-list role="list">
5151
<h3 mat-subheader>Folders</h3>
52-
<mat-list-item *ngFor="let folder of folders">
52+
<mat-list-item role="listitem" *ngFor="let folder of folders">
5353
<mat-icon mat-list-icon>folder</mat-icon>
5454
<h4 mat-line>{{folder.name}}</h4>
5555
<p mat-line class="demo-secondary-text"> {{folder.updated}} </p>
5656
</mat-list-item>
5757
<mat-divider></mat-divider>
5858
<h3 mat-subheader>Notes</h3>
59-
<mat-list-item *ngFor="let note of notes">
59+
<mat-list-item role="listitem" *ngFor="let note of notes">
6060
<mat-icon mat-list-icgon>note</mat-icon>
6161
<h4 mat-line>{{note.name}}</h4>
6262
<p mat-line class="demo-secondary-text"> {{note.updated}} </p>

src/lib/list/list.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ describe('MatList', () => {
115115

116116
let list = fixture.debugElement.children[0];
117117
let listItem = fixture.debugElement.children[0].query(By.css('mat-list-item'));
118-
expect(list.nativeElement.getAttribute('role')).toBeNull();
119-
expect(listItem.nativeElement.getAttribute('role')).toBe('listitem');
118+
expect(list.nativeElement.getAttribute('role')).toBeNull('Expect mat-list no role');
119+
expect(listItem.nativeElement.getAttribute('role')).toBeNull('Expect mat-list-item no role');
120120
});
121121

122122
it('should not show ripples for non-nav lists', () => {

src/lib/list/list.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ export class MatListSubheaderCssMatStyler {}
119119
selector: 'mat-list-item, a[mat-list-item]',
120120
exportAs: 'matListItem',
121121
host: {
122-
'role': 'listitem',
123122
'class': 'mat-list-item',
124123
'(focus)': '_handleFocus()',
125124
'(blur)': '_handleBlur()',
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<mat-list role="list">
2-
<mat-list-item>Item 1</mat-list-item>
3-
<mat-list-item>Item 2</mat-list-item>
4-
<mat-list-item>Item 3</mat-list-item>
2+
<mat-list-item role="listitem">Item 1</mat-list-item>
3+
<mat-list-item role="listitem">Item 2</mat-list-item>
4+
<mat-list-item role="listitem">Item 3</mat-list-item>
55
</mat-list>

0 commit comments

Comments
 (0)