Skip to content

fix(snack-bar): positioned snack bar animation not starting off-screen #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2017
Merged

fix(snack-bar): positioned snack bar animation not starting off-screen #7453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/lib/snack-bar/snack-bar-container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,29 @@ $mat-snack-bar-spacing-margin: 24px !default;
min-width: $mat-snack-bar-min-width;
padding: $mat-snack-bar-padding;
// Initial transformation is applied to start snack bar out of view, below its target position.
transform: translateY(100%);
// Note: it's preferred to use a series of transforms, instead of something like `calc()`, because
// IE won't animate transforms that contain a `calc`.
transform: translateY(100%) translateY($mat-snack-bar-spacing-margin);

/**
/**
* Removes margin of snack bars which are center positioned horizontally. This
* is done to align snack bars to the edge of the view vertically to match spec.
*/
&.mat-snack-bar-center {
margin: 0;
transform: translateY(100%);
}

/**
* To allow for animations from a 'top' vertical position to animate in a downward
* direction, set the translation to start the snack bar above the target position.
*/
&.mat-snack-bar-top {
transform: translateY(-100%);
transform: translateY(-100%) translateY(#{-$mat-snack-bar-spacing-margin});

&.mat-snack-bar-center {
transform: translateY(-100%);
}
}

@include cdk-high-contrast {
Expand Down
15 changes: 4 additions & 11 deletions src/lib/snack-bar/snack-bar-container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,10 @@ export const HIDE_ANIMATION = '195ms cubic-bezier(0.0,0.0,0.2,1)';
},
animations: [
trigger('state', [
// Animation from top.
state('visible-top', style({transform: 'translateY(0%)'})),
state('hidden-top', style({transform: 'translateY(-100%)'})),
transition('visible-top => hidden-top', animate(HIDE_ANIMATION)),
transition('void => visible-top', animate(SHOW_ANIMATION)),
// Animation from bottom.
state('visible-bottom', style({transform: 'translateY(0%)'})),
state('hidden-bottom', style({transform: 'translateY(100%)'})),
transition('visible-bottom => hidden-bottom', animate(HIDE_ANIMATION)),
transition('void => visible-bottom',
animate(SHOW_ANIMATION)),
state('visible-top, visible-bottom', style({transform: 'translateY(0%)'})),
transition('visible-top => hidden-top, visible-bottom => hidden-bottom',
animate(HIDE_ANIMATION)),
transition('void => visible-top, void => visible-bottom', animate(SHOW_ANIMATION)),
])
],
})
Expand Down