Skip to content

fix(snack-bar): positioned snack bar animation not starting off-screen #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 1, 2017

Currently, if a snack bar is positioned in one of the corners of the screen, it'll get a margin. This margin causes the snack bar's animation to start inside the viewport instead of off-screen. These changes fix the initial styling so the animation starts off-screen, in addition to simplifying some of the animation styles.

Currently, if a snack bar is positioned in one of the corners of the screen, it'll get a margin. This margin causes the snack bar's animation to start inside the viewport instead of off-screen. These changes fix the initial styling so the animation starts off-screen, in addition to simplifying some of the animation styles.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 3, 2017
@kara kara merged commit 58d3bb8 into angular:master Oct 5, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants