Skip to content

build: add tokens test for form field #27589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 6, 2023

A tokens test wasn't added in #27548, because MDC wasn't exporting the light theme variable that we validate against. I've made a change internally to export it so now we can validate against it.

A tokens test wasn't added in angular#27548, because MDC wasn't exporting the light theme variable that we validate against. I've made a change internally to export it so now we can validate against it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Aug 6, 2023
@crisbeto crisbeto requested a review from andrewseguin August 6, 2023 07:12
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 6, 2023
@crisbeto crisbeto self-assigned this Aug 7, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2023
@crisbeto crisbeto merged commit 7ed70fe into angular:main Aug 7, 2023
crisbeto added a commit that referenced this pull request Aug 7, 2023
A tokens test wasn't added in #27548, because MDC wasn't exporting the light theme variable that we validate against. I've made a change internally to export it so now we can validate against it.

(cherry picked from commit 7ed70fe)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants