refactor(material/form-field): switch to tokens theming API #27548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
force-pushed
the
form-field-tokens
branch
from
bbc647a to
6cb3fdf
Compare
andrewseguin
approved these changes
Aug 1, 2023
Switches the styles coming from MDC to the tokens theming API. There will be a follow-up PR to switch the remaining custom styles.
crisbeto
force-pushed
the
form-field-tokens
branch
from
6cb3fdf to
6d1544b
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 4, 2023
A tokens test wasn't added in angular#27548, because MDC wasn't exporting the light theme variable that we validate against. I've made a change internally to export it so now we can validate against it.
crisbeto
added a commit
that referenced
this pull request
Aug 7, 2023
A tokens test wasn't added in #27548, because MDC wasn't exporting the light theme variable that we validate against. I've made a change internally to export it so now we can validate against it.
crisbeto
added a commit
that referenced
this pull request
Aug 7, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the styles coming from MDC to the tokens theming API. There will be a follow-up PR to switch the remaining custom styles.