Skip to content

fix(material/chips): ensure that edit input query is re-evaluated on time #27465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 15, 2023

Fixes an issue that showed up in an internal app where the edit input query wasn't being evaluated on time which led to a runtime error.

Fixes #27462.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 15, 2023
@crisbeto crisbeto requested review from mmalerba and zarend as code owners July 15, 2023 07:03
@crisbeto crisbeto force-pushed the chips-editing-input branch from 6776a67 to 6df6e2c Compare July 15, 2023 07:05
@zarend zarend added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Jul 16, 2023
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added the dev-app-preview label so we can test this.

It's hard for me to verify this because I haven't been able to reproduce on any of our examples.

@github-actions
Copy link

github-actions bot commented Jul 16, 2023

Deployed dev-app for d121ddc to: https://ng-dev-previews-comp--pr-angular-components-27465-dw5loip3.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@crisbeto
Copy link
Member Author

I couldn't reproduce it against our dev app either. I was testing it in the internal demo.

@crisbeto crisbeto self-assigned this Jul 17, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 17, 2023
…time

Fixes an issue that showed up in an internal app where the edit input query wasn't being evaluated on time which led to a runtime error.

Fixes angular#27462.
@crisbeto crisbeto force-pushed the chips-editing-input branch from 6df6e2c to d121ddc Compare July 17, 2023 05:22
@crisbeto crisbeto merged commit 6045a0c into angular:main Jul 17, 2023
crisbeto added a commit that referenced this pull request Jul 17, 2023
…time (#27465)

Fixes an issue that showed up in an internal app where the edit input query wasn't being evaluated on time which led to a runtime error.

Fixes #27462.

(cherry picked from commit 6045a0c)
AnthonyFr75 pushed a commit to AnthonyFr75/components that referenced this pull request Jul 31, 2023
…time (angular#27465)

Fixes an issue that showed up in an internal app where the edit input query wasn't being evaluated on time which led to a runtime error.

Fixes angular#27462.
stephenrca pushed a commit to stephenrca/components that referenced this pull request Aug 2, 2023
…time (angular#27465)

Fixes an issue that showed up in an internal app where the edit input query wasn't being evaluated on time which led to a runtime error.

Fixes angular#27462.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(material/chips): Chip is cleared when entering the editing state.
2 participants