fix(material/chips): wait for onStable when editing a chip #27464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address timing issue with MatChipRow. When a chip enters the editing state wait for ngZone's `onStable` event before accessing the ViewChild for the MatChipEditInput. Attempts to fix issue where editable chip goes blank when entering the editing state (angular#27462). What seemed to be happening is that the view would render the MatChiEditInput when setting `_isEditing` to true, but sometimes the ViewChild would not be initialized in the component. Address this issue by adding additional wait using `_ngZone.onStable`. Fix angular#27462.
zarend
added
P3
|
Deployed dev-app for 2169f3f to: https://ng-dev-previews-comp--pr-angular-components-27464-rf0ldvar.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Closing in favor of #27465 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address timing issue with MatChipRow. When a chip enters the editing state wait for ngZone's
onStableevent before accessing the ViewChild for the MatChipEditInput. Attempts to fix issue where editable chip goes blank when entering the editing state (#27462).What seemed to be happening is that the view would render the MatChiEditInput when setting
_isEditingto true, but sometimes the ViewChild would not be initialized in the component. Address this issue by adding additional wait using_ngZone.onStable.Fix #27462.