Skip to content

docs: clean up explicit form field appearance #27103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

In #22837 we had to add appearance="fill" to all the examples to ensure a consistent appearance between the docs site and Stackblitz during the MDC transition. Now that the MDC components are the default, we don't need the explicit appearance anymore since fill is the default.

In angular#22837 we had to add `appearance="fill"` to all the examples to ensure a consistent appearance between the docs site and Stackblitz during the MDC transition. Now that the MDC components are the default, we don't need the explicit `appearance` anymore since `fill` is the default.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels May 16, 2023
@crisbeto crisbeto requested a review from devversion May 16, 2023 07:32
@crisbeto crisbeto requested a review from andrewseguin as a code owner May 16, 2023 07:32
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 16, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 16, 2023
@angular-robot angular-robot bot merged commit 6679684 into angular:main May 16, 2023
angular-robot bot pushed a commit that referenced this pull request May 16, 2023
In #22837 we had to add `appearance="fill"` to all the examples to ensure a consistent appearance between the docs site and Stackblitz during the MDC transition. Now that the MDC components are the default, we don't need the explicit `appearance` anymore since `fill` is the default.

(cherry picked from commit 6679684)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants