-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: explicitly set form field appearance #22837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explicitly set form field appearance #22837
Conversation
Currently the default form field appearance is `legacy`, but we switch it to `fill` only in Stackblitz since that's what we want to change the default to eventually. The problem with this approach is that the default is only changed on Stackblitz, not the docs site that user has to go through. These changes set the appearance to `fill` explicitly so that it is consistent.
Companion PR to angular/components#22837. Removes the default form field appearance so that we get a consistent result between the docs site and Stackblitz.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This has conflicts with the 12.0.x branch, needs another PR for that branch so the patch release docs don't lose their fill appearance when we merge the m.aio PR |
I think that it won't be a big deal if we make the docs site change now and this waits until the next minor release. The current behavior is already broken since the changed default only applies when forked to Stackblitz, not on the docs site itself. |
The thing is we don't have separate release branches on angular/material.angular.io so the docs site change will wind up applying to both patch and minor releases. Therefore we need this to land on both branches |
I don't think that's a big deal either. I think that the current behavior is more broken compared to the behavior after this change. |
I'll at least merge this for now. If we don't want the appearance to change on the form-fields we can hold off on merging the docs site change until 12.1.0 comes out |
Shouldn't we be changing the component's default to |
Companion PR to angular/components#22837. Removes the default form field appearance so that we get a consistent result between the docs site and Stackblitz.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the default form field appearance is
legacy
, but we switch it tofill
only in Stackblitz since that's what we want to change the default to eventually. The problem with this approach is that the default is only changed on Stackblitz, not the docs site that user has to go through.These changes set the appearance to
fill
explicitly so that it is consistent.Companion PR for the docs site: angular/material.angular.io#1002