Skip to content

fix(material/chips): chips should assume their minimum density rather than error for small densities #26688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(material/chips): chips should assume their minimum density rather than error for small densities #26688

merged 1 commit into from
Feb 28, 2023

Conversation

mmalerba
Copy link
Contributor

Fixes #26613

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 23, 2023
@mmalerba mmalerba requested a review from zarend February 23, 2023 22:14
@mmalerba mmalerba added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Feb 23, 2023
crisbeto
crisbeto approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zarend
zarend approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the change to package.json intentional?

@devversion
Copy link
Member

The package.json change should be fine. We need it because Github actions run with v18 NodeJS now. @mmalerba I've landed the dev-infra update, so preview action should work after rebase.

@devversion devversion removed their request for review February 27, 2023 13:31
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 27, 2023
@angular-robot angular-robot bot merged commit c4c57f7 into angular:main Feb 28, 2023
angular-robot bot pushed a commit that referenced this pull request Feb 28, 2023
@mmalerba
fix(material/chips): chips should assume their minimum density rather…
fdf1dc4 
… than error for small densities (#26688)

(cherry picked from commit c4c57f7)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 3, 2023
Update angularmaterial monorepo to v15.2.1 (#1800)
4cd50a1 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.0` -> `15.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.0/15.2.1) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.0` -> `15.2.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.0/15.2.1) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.2.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1521-silicone-soliloquy-2023-03-01)

[Compare Source](angular/components@15.2.0...15.2.1)

#### Breaking Changes

#####

-   the description for body-1 and body-2 has changed

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [9a57674fea](angular/components@9a57674) | fix | **chips:** allow attribute selectors for chips ([#&#8203;26683](angular/components#26683)) |
| [fdf1dc4b07](angular/components@fdf1dc4) | fix | **chips:** chips should assume their minimum density rather than error for small densities ([#&#8203;26688](angular/components#26688)) |
| [d61443b62d](angular/components@d61443b) | fix | **chips:** remove spans from top level of component ([#&#8203;26689](angular/components#26689)) |
| [5e67c1a345](angular/components@5e67c1a) | fix | **chips:** styling not updating when actions are removed ([#&#8203;26696](angular/components#26696)) |
| [a87735e4ba](angular/components@a87735e) | fix | **list:** add disabled attribute for mat-list-item buttons ([#&#8203;26672](angular/components#26672)) |
| [54d157f3d2](angular/components@54d157f) | fix | **schematics:** migrate to mdc components selectively bug ([#&#8203;26427](angular/components#26427)) |
| [4338e5ee57](angular/components@4338e5e) | fix | **snack-bar:** misaligned lines on safari for long messages ([#&#8203;26692](angular/components#26692)) |

#####

| Commit | Type | Description |
| -- | -- | -- |
| [b71fa77f7d](angular/components@b71fa77) | docs | reverse body-1 and body-2 typography description ([#&#8203;26330](angular/components#26330)) |

#### Special Thanks

Hamza jayri, Kristiyan Kostadinov, Matthieu Riegler, Miles Malerba, OneSidedPrism, VICTORIA JOHNSON and llorenspujol

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1800
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@gregmagolan gregmagolan mentioned this pull request Mar 8, 2023
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@zarend zarend zarend approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@zarend zarend

Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(theme): applying density "mat.all-component-densities(-3);" and "mat.chips-density(-3)" crashes compilation
4 participants
@mmalerba @devversion @crisbeto @zarend