Skip to content

reverse body-1 and body-2 description #26330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

reverse body-1 and body-2 description #26330

merged 2 commits into from
Feb 28, 2023

Conversation

DrVickie8
Copy link
Contributor

@DrVickie8 DrVickie8 commented Dec 27, 2022 •
edited
Loading

docs(material/typography): reverse body-1 and body-2 description

Reverse the description of body-1 and body-2 in the documentation for 'Typography levels'. Looking at how mat-body-1 (mat-h4) and mat-body-2 (mat-body) classes are applied, it seems that the descriptions in the documentation are reversed.

BREAKING CHANGE: the description for body-1 and body-2 has changed
Closes #26251

@DrVickie8 DrVickie8 requested a review from jelbourn as a code owner December 27, 2022 10:36
@angular-robot angular-robot bot added area: docs Related to the documentation detected: breaking change PR contains a commit with a breaking change labels Dec 27, 2022
@DrVickie8
Copy link
Contributor Author

Hello @jelbourn,
How can I pass the "ci/angular: merge status" and "ci/circleci: lint" tests?
I've been trying to create a PR for a while now, and it's my first time here.

@mmalerba mmalerba added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Feb 1, 2023
mmalerba
mmalerba reviewed Feb 1, 2023
View reviewed changes
@mmalerba
Copy link
Contributor

mmalerba commented Feb 1, 2023

The lint check is failing because the commit message doesn't match our expected format for the merge commits. You don't need to worry about it though, we can fix it when we merge the PR

DrVickie8 and others added 2 commits February 28, 2023 23:46
@DrVickie8 @mmalerba
docs(guide): reverse body-1 and body-2 description
e559f3f 
Reverse the description of body-1 and body-2 in the documentation for 'Typography levels'. Looking at how mat-body-1 (mat-h4) and mat-body-2 (mat-body) classes are applied, it seems that the descriptions in the documentation are reversed.

BREAKING CHANGE: the description for body-1 and body-2 has changed

Closes angular#26251
@mmalerba
update descriptions
792cb6d
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Feb 28, 2023
@angular-robot angular-robot bot merged commit 25c1178 into angular:main Feb 28, 2023
angular-robot bot pushed a commit that referenced this pull request Feb 28, 2023
@DrVickie8 @mmalerba
docs: reverse body-1 and body-2 typography description (#26330)
b71fa77 
Reverse the description of body-1 and body-2 in the documentation for 'Typography levels'. Looking at how mat-body-1 (mat-h4) and mat-body-2 (mat-body) classes are applied, it seems that the descriptions in the documentation are reversed.

BREAKING CHANGE: the description for body-1 and body-2 has changed

Closes #26251

* update descriptions

(cherry picked from commit 25c1178)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 3, 2023
Update angularmaterial monorepo to v15.2.1 (#1800)
4cd50a1 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.0` -> `15.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.0/15.2.1) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.0` -> `15.2.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.0/15.2.1) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.2.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1521-silicone-soliloquy-2023-03-01)

[Compare Source](angular/components@15.2.0...15.2.1)

#### Breaking Changes

#####

-   the description for body-1 and body-2 has changed

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [9a57674fea](angular/components@9a57674) | fix | **chips:** allow attribute selectors for chips ([#&#8203;26683](angular/components#26683)) |
| [fdf1dc4b07](angular/components@fdf1dc4) | fix | **chips:** chips should assume their minimum density rather than error for small densities ([#&#8203;26688](angular/components#26688)) |
| [d61443b62d](angular/components@d61443b) | fix | **chips:** remove spans from top level of component ([#&#8203;26689](angular/components#26689)) |
| [5e67c1a345](angular/components@5e67c1a) | fix | **chips:** styling not updating when actions are removed ([#&#8203;26696](angular/components#26696)) |
| [a87735e4ba](angular/components@a87735e) | fix | **list:** add disabled attribute for mat-list-item buttons ([#&#8203;26672](angular/components#26672)) |
| [54d157f3d2](angular/components@54d157f) | fix | **schematics:** migrate to mdc components selectively bug ([#&#8203;26427](angular/components#26427)) |
| [4338e5ee57](angular/components@4338e5e) | fix | **snack-bar:** misaligned lines on safari for long messages ([#&#8203;26692](angular/components#26692)) |

#####

| Commit | Type | Description |
| -- | -- | -- |
| [b71fa77f7d](angular/components@b71fa77) | docs | reverse body-1 and body-2 typography description ([#&#8203;26330](angular/components#26330)) |

#### Special Thanks

Hamza jayri, Kristiyan Kostadinov, Matthieu Riegler, Miles Malerba, OneSidedPrism, VICTORIA JOHNSON and llorenspujol

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1800
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@gregmagolan gregmagolan mentioned this pull request Mar 8, 2023
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation detected: breaking change PR contains a commit with a breaking change merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(Typography): Description on mat-body-1 and -2 appear reversed
2 participants
@DrVickie8 @mmalerba