Skip to content

feat(cdk/tree): implement expansion methods for TreeKeyManager #26586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BobobUnicorn
Copy link
Collaborator

@BobobUnicorn BobobUnicorn commented Feb 7, 2023

Based on #24659. Followed by #26587.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 7, 2023
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y-expand branch 6 times, most recently from 3ae2203 to 31b125d Compare February 17, 2023 22:00
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y-expand branch from 31b125d to 8d0c33c Compare March 13, 2023 19:21
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y-expand branch 5 times, most recently from 69903ce to 727f8b6 Compare April 11, 2023 18:51
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y-expand branch 3 times, most recently from 6804d4b to 3e19403 Compare April 18, 2023 18:38
@BobobUnicorn BobobUnicorn changed the base branch from main to cdk-tree-revamp April 18, 2023 18:48
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y-expand branch from 3e19403 to fd61cd6 Compare April 19, 2023 19:21
@andrewseguin
Copy link
Contributor

Rebase and we can merge

@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y-expand branch from fd61cd6 to bbfea90 Compare May 4, 2023 17:55
@angular-robot angular-robot bot requested a review from andrewseguin May 4, 2023 17:56
@BobobUnicorn BobobUnicorn marked this pull request as ready for review May 4, 2023 17:56
@BobobUnicorn
Copy link
Collaborator Author

sorry about the delay, oncall shenanigans 😛

@andrewseguin andrewseguin merged commit ef8a166 into angular:cdk-tree-revamp May 4, 2023
andrewseguin pushed a commit that referenced this pull request May 30, 2023
* feat(cdk/a11y): implement expansion methods

* feat(cdk/a11y): add tests and fixes for expand/collapse interactions

* feat(cdk/a11y): actually fix build

* feat(cdk/a11y): use skipPredicate instead of disabled
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
@BobobUnicorn BobobUnicorn deleted the cdk-tree-a11y-expand branch October 5, 2023 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants