feat(cdk/a11y): add a TreeKeyManager, with next/prev implemented #24659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
a223201 to
3f04ccb
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
3f04ccb to
8c005c0
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
2 times, most recently
from
7fb72ab to
b05d681
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
b05d681 to
879f372
Compare
andrewseguin
force-pushed
the
cdk-tree-revamp
branch
from
8b3a358 to
3a91226
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
2 times, most recently
from
dbb8216 to
2c7c9c2
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
2c7c9c2 to
f60f486
Compare
This was referenced Feb 7, 2023
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
f60f486 to
fe9f5b0
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
6 times, most recently
from
ef83adc to
07508e0
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
07508e0 to
8ac1671
Compare
andrewseguin
force-pushed
the
cdk-tree-revamp
branch
2 times, most recently
from
565eb38 to
fbe321d
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
8ac1671 to
41a3ad3
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
6 times, most recently
from
8b6c70d to
c53c2fa
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-next-prev
branch
from
c53c2fa to
0a5fbcd
Compare
andrewseguin
approved these changes
Apr 19, 2023
|
Ready to merge when you want to publish this out of a draft |
andrewseguin
pushed a commit
that referenced
this pull request
May 30, 2023
) * feat(cdk/a11y): add API for TreeKeyManager * feat(cdk/a11y): add activeItem into the TreeKeyManager * feat(cdk/a11y): store the options into the key manager * feat(cdk/a11y): add _getItems translation layer * feat(cdk/a11y): add skeleton for keydown actions * feat(cdk/a11y): implement activate item * feat(cdk/a11y): implement various focus methods * feat(cdk/a11y): implement onClick, remove lint disables * feat(cdk/a11y): partial spec migration, fixed some bugs in impl * fix(cdk/tree): fix lint errors * fix(cdk/a11y): fix lint errors pt2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #24658. Followed by #26586.