Skip to content

build: add lint rule to disallow type-only imports/exports #24678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2022
Merged

build: add lint rule to disallow type-only imports/exports #24678

merged 1 commit into from
Mar 27, 2022

Conversation

crisbeto
Copy link
Member

Type-only imports and exports don't work with Closure so we can't use them.

@crisbeto
build: add lint rule to disallow type-only imports/exports
3008c6c 
Type-only imports and exports don't work with Closure so we can't use them.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: major This PR is targeted for the next major release labels Mar 27, 2022
@crisbeto crisbeto requested a review from a team as a code owner March 27, 2022 10:11
@crisbeto crisbeto mentioned this pull request Mar 27, 2022
Closed
devversion
devversion approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If this is something we want to use in FW as well, we can consider moving it to dev-infra's set of tslint rules.

(although this is obviously a super short rule)

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2022
@crisbeto crisbeto merged commit 4f01bac into angular:master Mar 27, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@crisbeto @forsti0506
build: add lint rule to disallow type-only imports/exports (angular#2…
12ad974 
…4678)

Type-only imports and exports don't work with Closure so we can't use them.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @devversion